Adding MSETEX command support. #3823
Merged
+796
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for the Redis MSETEX command, which sets multiple key-value pairs with optional expiration settings. The implementation introduces tests and cluster support for this new command.
- Adds the
DataPersistOptionsenum (NX/XX) to control conditional setting behavior - Implements the
msetexmethod inredis/commands/core.pywith support for various expiration options (ex, px, exat, pxat, keepttl) - Adds comprehensive test coverage for both sync and async clients
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 10 comments.
| File | Description |
|---|---|
| redis/commands/core.py | Adds DataPersistOptions enum and implements the msetex method with expiration and conditional setting options |
| redis/cluster.py | Registers "MSETEX" as a cluster-compatible command |
| tests/test_commands.py | Adds comprehensive test cases for msetex with various expiration options and conditional settings |
| tests/test_asyncio/test_commands.py | Adds async versions of msetex test cases |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
petyaslavova
force-pushed
the
ps_add_key_expiration_to_common_commands
branch
from
2492b5f to
81abba2
Compare
…and pipelines in clusters
petyaslavova
force-pushed
the
ps_add_key_expiration_to_common_commands
branch
from
81abba2 to
a24b9c2
Compare
Contributor
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 7 out of 7 changed files in this pull request and generated 7 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
vladvildanov
approved these changes
Nov 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request check-list
Please make sure to review and check all of these items:
NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.
Description of change
Please provide a description of the change here.